httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r1407459 - /httpd/httpd/trunk/modules/metadata/mod_remoteip.c
Date Fri, 09 Nov 2012 16:44:24 GMT
Nah, cause what's printed is "": eg 'Using %s as client's IP by internal proxies'

If we had a space there, what would be printed is: 'Using %s as client's IP by internal proxies
'

On Nov 9, 2012, at 11:29 AM, Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
wrote:

> 
> Le 09/11/2012 15:04, jim@apache.org a écrit :
>> Modified: httpd/httpd/trunk/modules/metadata/mod_remoteip.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/metadata/mod_remoteip.c?rev=1407459&r1=1407458&r2=1407459&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/metadata/mod_remoteip.c (original)
>> +++ httpd/httpd/trunk/modules/metadata/mod_remoteip.c Fri Nov  9 14:04:19 2012
>> @@ -400,8 +400,9 @@ static int remoteip_modify_request(reque
>>      ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
>>                    req->proxy_ips
>>                        ? "Using %s as client's IP by proxies %s"
>> -                      : "Using %s as client's IP by internal proxies",
>> -                  req->useragent_ip, req->proxy_ips);
>> +                      : "Using %s as client's IP by internal proxies%s",
> Space missing between proxies and %s ?
> 
> 
>> +                  req->useragent_ip,
>> +                  (req->proxy_ips ? req->proxy_ips : ""));
>>      return OK;
>>  }
> 


Mime
View raw message