Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: softfail (nike.apache.org: transitioning domain of
 vincent@gryzor.com does not designate 212.27.42.3 as permitted sender)
Message-ID: <5077D66D.1080904@gryzor.com>
Date: Fri, 12 Oct 2012 10:35:57 +0200
From: Vincent Deffontaines <vincent@gryzor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:10.0.7) Gecko/20120922 Icedove/10.0.7
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: [Patch] Support for Fallbackresource disabled
Content-Type: multipart/mixed;
 boundary="------------080705000102090803060007"

This is a multi-part message in MIME format.
--------------080705000102090803060007
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Greetings,

While providing support on IRC, I noticed that FallbackResource lacks a
'turn-off' switch.
Since it works in per dir config, it seems sane that it could be
valuable to turn it off in chosen subdirs.
This one liner patch adds support for the keyword 'disabled' (stolen
from userdir).
Of course, the pitfall is that you cannot fallbackresource to a resource
named "disabled".

This patch is against 2.4. I will commit the updated documentation and
suggest the same patch for 2.2 if this is accepted.

Regards,

Gryzor


-- 
"I never look behind me, my troubles will be few"
Supertramp

--------------080705000102090803060007
Content-Type: text/x-diff;
 name="mod_dir_fallbackresource_disabled.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
 filename="mod_dir_fallbackresource_disabled.patch"

Index: mod_dir.c
===================================================================
--- mod_dir.c   (révision 1397126)
+++ mod_dir.c   (copie de travail)
@@ -162,7 +163,7 @@
     int error_notfound = 0;

     name_ptr = d->dflt;
-    if (name_ptr == NULL) {
+    if ((name_ptr == NULL) || !(strcasecmp(name_ptr,"disabled"))){
         return DECLINED;
     }
     /* XXX: if FallbackResource points to something that doesn't exist,

--------------080705000102090803060007--