httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject Question about errors in 'mpm_service_install' (server/mpm/winnt/service.c)
Date Mon, 15 Oct 2012 19:40:54 GMT
Hi,

in the function 'mpm_service_install' in server/mpm/winnt/service.c, 
cppcheck complains on line 596 and line 608 about 'Same expression on 
both sides of '|'.'

596:        ap_log_error(APLOG_MARK, APLOG_ERR|APLOG_ERR,<--- Same 
expression on both sides of '|'.
                          apr_get_os_error(), NULL,
                          "OpenService failed");

608:        ap_log_error(APLOG_MARK, APLOG_ERR|APLOG_ERR,<--- Same 
expression on both sides of '|'.
                          apr_get_os_error(), NULL,
                          "ChangeServiceConfig failed");


According to surrounding code, I assume that the second APLOG_ERR should 
be APLOG_STARTUP.

Any idea ?


Best regards,
CJ



Mime
View raw message