httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: svn commit: r1032431 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_rewrite.c
Date Thu, 04 Oct 2012 18:38:05 GMT
On Thu, Oct 4, 2012 at 2:05 PM, Graham Leggett <minfrin@sharp.fm> wrote:
> On 4 Oct 2012, at 17:32, Eric Covener <covener@gmail.com> wrote:
>
>>> URL: http://svn.apache.org/viewvc?rev=1032431&view=rev
>>> Log:
>>> mod_rewrite: Fix the RewriteEngine directive to work within a
>>> location. Previously, once RewriteEngine was switched on globally,
>>> it was impossible to switch off.
>>>
>>> +    a->baseurl = (overrides->baseurl_set == 0) ? base->baseurl : overrides->baseurl;
>>> +    a->baseurl_set = overrides->baseurl_set || base->baseurl_set;
>>
>>
>> PR https://issues.apache.org/bugzilla/show_bug.cgi?id=53963 points out
>> that mergeing the base is probably not very useful and actually harms
>> configs where no rewritebase is required in some subdirs but present
>> in parent dirs.
>>
>> Any issue with dropping this part of the change?
>
> Having an arbitrary inconsistent behaviour from a directive in a module already noted
for its complexity is a really bad thing. What we should support instead is the ability to
turn RewriteBase off if needed, with something like "RewriteBase off".

"Rewritebase off" to undo the copy of base URL from the parent to the
subdir seems wrong.  I'll try to merge in a value less likely to be
wrong.

Mime
View raw message