httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: svn commit: r1032431 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_rewrite.c
Date Thu, 04 Oct 2012 16:32:42 GMT
On Sun, Nov 7, 2010 at 7:41 PM,  <minfrin@apache.org> wrote:
> Author: minfrin
> Date: Mon Nov  8 00:41:35 2010
> New Revision: 1032431
>
> URL: http://svn.apache.org/viewvc?rev=1032431&view=rev
> Log:
> mod_rewrite: Fix the RewriteEngine directive to work within a
> location. Previously, once RewriteEngine was switched on globally,
> it was impossible to switch off.
>
> +    a->baseurl = (overrides->baseurl_set == 0) ? base->baseurl : overrides->baseurl;
> +    a->baseurl_set = overrides->baseurl_set || base->baseurl_set;


PR https://issues.apache.org/bugzilla/show_bug.cgi?id=53963 points out
that mergeing the base is probably not very useful and actually harms
configs where no rewritebase is required in some subdirs but present
in parent dirs.

Any issue with dropping this part of the change?

(rewritebase is needed when a relative substitution is made and the
current URL and the current URL was reached via e.g. alias and not
under the documentroot)

Mime
View raw message