httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r1032431 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_rewrite.c
Date Thu, 04 Oct 2012 23:18:23 GMT
On 04 Oct 2012, at 9:18 PM, André Malo <nd@perlig.de> wrote:

> Hmm. The very sole concept of RewriteBase is "base for this location and 
> this location only".

Exactly, which is why merging is the only sensible behaviour. "/foo/bar" is below location
"/foo" at all times, regardless of whether someone has added <Location /foo/bar> to
their config or not. Until someone has explicitly stated otherwise, /foo/bar should have the
same RewriteBase as /foo.

Not merging properly means that the addition of a completely unrelated directive such as RewriteRule
to a Location that previously had only inherited RewriteRules suddenly makes the RewriteBase
vanish completely without warning.

We should not try and second guess what the user is trying to achieve. Have a sensible consistent
behaviour and let the end user make up their own mind as to how to configure it.

> So merging is most certainly a nogo. It *will* break 
> stuff. mod_rewrite already has enough bad guessings built in ;)

The idea is to take out the bad guessing, not maintain it.

Regards,
Graham
--


Mime
View raw message