Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0A65DD438 for ; Tue, 18 Sep 2012 18:09:50 +0000 (UTC) Received: (qmail 58584 invoked by uid 500); 18 Sep 2012 18:09:49 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 58511 invoked by uid 500); 18 Sep 2012 18:09:49 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 58503 invoked by uid 99); 18 Sep 2012 18:09:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2012 18:09:49 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 76.96.62.32 is neither permitted nor denied by domain of jim@jagunet.com) Received: from [76.96.62.32] (HELO qmta03.westchester.pa.mail.comcast.net) (76.96.62.32) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2012 18:09:41 +0000 Received: from omta15.westchester.pa.mail.comcast.net ([76.96.62.87]) by qmta03.westchester.pa.mail.comcast.net with comcast id 0cE41k00j1swQuc53i9Rl7; Tue, 18 Sep 2012 18:09:25 +0000 Received: from [192.168.199.10] ([69.251.80.74]) by omta15.westchester.pa.mail.comcast.net with comcast id 0iAN1k00C1cCKD93biAPxb; Tue, 18 Sep 2012 18:10:24 +0000 Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.0 \(1486\)) Subject: Re: svn commit: r1387110 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_proxy.xml include/ap_mmn.h modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c modules/proxy/proxy_util.c From: Jim Jagielski In-Reply-To: <5058A0C3.1040803@vodafone.com> Date: Tue, 18 Sep 2012 14:09:19 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <5058A0C3.1040803@vodafone.com> To: dev@httpd.apache.org X-Mailer: Apple Mail (2.1486) X-Virus-Checked: Checked by ClamAV on apache.org On Sep 18, 2012, at 12:26 PM, R=FCdiger Pl=FCm = wrote: > URL: = http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.c?r= ev=3D1387110&r1=3D1387109&r2=3D1387110&view=3Ddiff > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- httpd/httpd/trunk/modules/proxy/mod_proxy.c (original) > +++ httpd/httpd/trunk/modules/proxy/mod_proxy.c Tue Sep 18 12:15:50 = 2012 > @@ -1145,13 +1145,14 @@ static void * create_proxy_config(apr_po > #if 0 > id =3D ap_proxy_hashfunc(apr_psprintf(p, "%pp-%" APR_TIME_T_FMT, = ps, apr_time_now()), PROXY_HASHFUNC_DEFAULT); > #else > - id =3D ap_proxy_hashfunc(apr_psprintf(p, "%pp", ps), = PROXY_HASHFUNC_DEFAULT); > + id =3D ap_proxy_hashfunc(apr_psprintf(p, "%pp", s), = PROXY_HASHFUNC_DEFAULT); >=20 > Wouldn't multiple balancers within the same virtual server end up wit = the same id now? >=20 That ID is used to store the conf slot, which stores the list of balancers for that server. Each balancer has it's own slotmem instance which houses the workers. Since 's' survives restarts, the conf->id remains constant and thus we can restore.