Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of apache-dev@m.gmane.org
 designates 80.91.229.3 as permitted sender)
To: dev@httpd.apache.org
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: Clang Checkers
Date: Fri, 14 Sep 2012 22:39:34 +0200
Lines: 70
Message-ID: <50539606.4000407@wanadoo.fr>
References: <a5966cc9-4d7a-4acf-bdbf-85d6ee061323@iris>
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------020906070603090904030407"
Cc: =?UTF-8?B?SWdvciBHYWxpxIc=?= <i.galic@brainsware.org>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:15.0) Gecko/20120827 Thunderbird/15.0
In-Reply-To: <a5966cc9-4d7a-4acf-bdbf-85d6ee061323@iris>

This is a multi-part message in MIME format.
--------------020906070603090904030407
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

this one remove a dead assignment and reduce the scope of a variable.

  mod_proxy_balancer.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

Best regards,
CJ


On 09/14/2012 08:10 PM, Igor Galić wrote:
>
> Hey folks,
>
> over at trafficserver we started looking into running
> clang's checkers over our code. Using the momentum, Daniel
> and myself rand the checkers over httpd and apr (both from
> trunk) as well.
>
> Daniel's checks are ran under FreeBSD/clang 3.0:
>
>     http://inhouse.humbedooh.com/clang/2012-09-14-3/
>
> Mine are ran under Fedora and clang 3.2 (trunk):
>
>     http://people.apache.org/~igalic/checks/httpd/latest/
>
>
> So long,
>
> i
>


--------------020906070603090904030407
Content-Type: text/x-patch;
 name="diff_httpd.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="diff_httpd.diff"

Index: modules/proxy/mod_proxy_balancer.c
===================================================================
--- modules/proxy/mod_proxy_balancer.c	(revision 1384907)
+++ modules/proxy/mod_proxy_balancer.c	(working copy)
@@ -702,7 +702,6 @@
                          apr_pool_t *ptemp, server_rec *s)
 {
     apr_status_t rv;
-    void *sconf = s->module_config;
     proxy_server_conf *conf;
     ap_slotmem_instance_t *new = NULL;
     apr_time_t tstamp;
@@ -744,7 +743,7 @@
     while (s) {
         int i,j;
         proxy_balancer *balancer;
-        sconf = s->module_config;
+        void *sconf = s->module_config;
         conf = (proxy_server_conf *)ap_get_module_config(sconf, &proxy_module);
 
         if (conf->bslot) {

--------------020906070603090904030407--