httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] mod_cache_socache store_headers rc issues
Date Fri, 28 Sep 2012 11:11:06 GMT
On 27 Sep 2012, at 4:18 PM, Jeff Trawick <trawick@gmail.com> wrote:

> gcc mentioned that rv was returned without being set, and after
> looking a bit I noticed a few other glitches.
> 
> Any comments on the untested patch?

Any attempt at returning DECLINED is wrong at this point, as by the time we're calling store_headers()
we're committed to this backend. I've updated all the lines where this was being returned
in r1391396, thanks for catching this.

> (I also see that the APLOGNO() invocations need to be fixed, but I
> haven't looked further.)

Oops, that's fixed in r1391398.

Regards,
Graham
--


Mime
View raw message