httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: Linking mod_ssl with a specific OpenSSL version
Date Tue, 18 Sep 2012 13:05:26 GMT
On Sun, Sep 16, 2012 at 08:00:00AM +0200, Kaspar Brand wrote:
> I have committed an improved version in r1385214 (in particular, more
> tweaking was required to properly handle support/ab, which can't make
> use of MOD_CFLAGS etc.). Reviews, further testing and feedback welcome.

Looks good to me, thanks Kaspar.

one minor nit/bikeshed-colour-review:

-           APR_ADDTO(MOD_SSL_LDADD, [-export-symbols-regex ssl_module])
+           APR_ADDTO(MOD_LDFLAGS, [-export-symbols-regex ssl_module])

this is currently equivalent but keeping _LDADD seems better.

Regards, Joe

Mime
View raw message