Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5084EDC8B for ; Wed, 29 Aug 2012 08:41:09 +0000 (UTC) Received: (qmail 63270 invoked by uid 500); 29 Aug 2012 08:41:08 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 62504 invoked by uid 500); 29 Aug 2012 08:41:03 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 62462 invoked by uid 99); 29 Aug 2012 08:41:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2012 08:41:02 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of hwguy.siplus@gmail.com designates 74.125.83.45 as permitted sender) Received: from [74.125.83.45] (HELO mail-ee0-f45.google.com) (74.125.83.45) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2012 08:40:53 +0000 Received: by eeke53 with SMTP id e53so159943eek.18 for ; Wed, 29 Aug 2012 01:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=09wHDLHSSrP/9JdAWXD4wcQjGOVms2avbAVYTLhtFlQ=; b=FBwHw3n7VPF029XgSlCVdR8jM7Dpj3qN2UDmYmPVrBKq4B7NEgw/BHKLalbzFAojqi 5POSl0eO12MNZwPCJpaxOj7aMBHkOhYN7FGWknyWehKQMmykhoQXKZMR2cYnAuEyEmLk e+66sAi6TYdfa4or1skz7DEb2hf0ePSsms9jasFSvn8sXdAHrnQ0ZEd2t3nu6wcM0Xx4 vzoWlpN4cpjHOoW/rT+I9zx0Rs6zqNKLM+77oqfuN9RlZBGW8+gBMXPXeCCBfZYOM7a5 WcQZ80m5zlN+b0c+DHY/ZAoVNiyfWsDJThJTnffRZKljsxBWzx7+dGjaY7i7d1vqi2/e B4tw== Received: by 10.14.218.5 with SMTP id j5mr987634eep.16.1346229633274; Wed, 29 Aug 2012 01:40:33 -0700 (PDT) Received: from [192.168.0.222] ([31.133.247.46]) by mx.google.com with ESMTPS id u47sm67852938eeo.9.2012.08.29.01.40.32 (version=SSLv3 cipher=OTHER); Wed, 29 Aug 2012 01:40:32 -0700 (PDT) Message-ID: <503DD574.6050908@gmail.com> Date: Wed, 29 Aug 2012 12:40:20 +0400 From: SiPlus User-Agent: Mozilla/5.0 (Windows NT 6.2; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: dev-digest@httpd.apache.org, dev@httpd.apache.org Subject: Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hello, dev@. I request a little change to HTTPD code. On line 58 of server/util_md5.c, please replace char *r, result[33]; /* (MD5_DIGESTSIZE * 2) + 1 */ with char *r, result[2*APR_MD5_DIGESTSIZE+1]; There's only constant arithmetic here, so I don't see a reason to pre-calculate the size here, and other code files use 2*APR_MD5_DIGESTSIZE+1 often. Thanks, SiPlus