httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h
Date Mon, 27 Aug 2012 09:59:33 GMT


> -----Original Message-----
> From: Daniel Gruno [mailto:rumble@cord.dk]
> Sent: Montag, 27. August 2012 10:45
> To: dev@httpd.apache.org
> Subject: Re: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES
> docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js
> modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h
> 
> On 08/27/2012 09:41 AM, Rüdiger Plüm wrote:
> 
> > +    /* Clean up and pass on the brigade to the next filter in the
> chain */
> >
> >
> > Where do we do a cleanup here?
> >
> > +    return APR_SUCCESS;
> > +}
> > +
> <snip>
> >
> > Regards
> >
> > Rüdiger
> >
> Heh, I believe that's what is called a copypasto. Both cleanups and
> passing on content is done earlier in the chain, the specific comment is
> simply a remnant of creating the input filter based on the code used for
> the output filter (you'll see the same comment in the output filter
> code, where it actually makes sense). I'll remove the comment.

Thanks. I guess you noticed that I found more important issues with the code than this comment
:-)

Regards

Rüdiger

Mime
View raw message