httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: server config with ap_set_int_slot seg faults
Date Sat, 25 Aug 2012 16:16:22 GMT
On Sat, 25 Aug 2012 17:28:10 +0200
Alexandru Crivat <alex@crivat.eu> wrote:

> I have a configuration directive (ArcMaxRequestSize) in httpd.conf at the
> top level which makes apache segfault in the start-up phase when using my
> module.
> It seems to me that only per-dir config is taken into account which seems
> really weird ...

You seem to have diagnosed the problem yourself.
Yes, it's anomalous, but really ap_set_int_slot
and family are really just there as minor conveniences
to save you re-inventing widely-used wheels.
Noone has implemented the same for per-server config,
and some folks want to phase out all per-server stuff.

> If I modiffy this to:
> 
> 1068         ap_set_module_config(server->module_config, mod,
> server_config);
> 1069     }
> 1070    if(NULL == section_config)
> 1071        return server_config;
> 1072    return section_config;
> 1073 }
> 
> then everything works fine and as (I) expected.

That's an interesting (implied) patch, and OTTOMH it
looks good.  Have we all been missing a nice little
trick all this time?

> Thanks in advance for your help,

Who is helping whom here?


However, I do see an issue here:

> =============== BEGIN httpd.conf (extract)  =========================
> LoadModule arc_module modules/mod_arc.so
> ArcMaxRequestSize 22222
> <Location /arc>
>     SetHandler arc
> </Location>

Is there any reason not to use per-dir config for ArcMaxRequestSize?
That way it could go with the SetHandler!


-- 
Nick Kew

Mime
View raw message