httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: [PATCH] Re: ProxyBlock question
Date Tue, 24 Jul 2012 10:05:34 GMT


> -----Original Message-----
> From: Joe Orton [mailto:jorton@redhat.com]
> Sent: Dienstag, 24. Juli 2012 11:37
> To: dev@httpd.apache.org
> Subject: [PATCH] Re: ProxyBlock question
> 
> On Tue, Jul 24, 2012 at 08:42:34AM +0000, Plüm, Rüdiger, Vodafone Group
> wrote:
> > So after this rant I come to the conclusion that your proposed
> approach is the best:
> >
> > Only compare the names and not the IP's in the proxy case.
> 
> Attached does this - any comments?  I suppose this requires a major MMN
> bump?  Can backport it in a backwards-compat way for 2.4.x, though.

Looks good. Slight optimization:

If addr == NULL we can just skip the whole  while (conf_addr) {
loop.

Regards

Rüdiger
Mime
View raw message