httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zisis Lianas <Zisis.Lia...@consol.de>
Subject Re: httpd 2.4.2 - mod_proxy id name not unique
Date Wed, 09 May 2012 21:49:08 GMT
Hi Jim,

ok, that looks reasonable.

So it would make sense to introduce something like a prefix
directive for "proxy_server_conf->id" (e.g. ProxyConfigIdPrefix)?
Otherwise we could use some unique host property for that prefix?

Also some relative directory directive for all slotmem files
in mod_proxy_balancer would be nice (ap_slotmem_provider_t->create).
Maybe "BalancerSlotmemDir". So DefaultRuntimeDir + BalancerSlotmemDir
would build up the path for the slotmem files.



Best regards,
Zisis

----- Original Message -----
From: "Jim Jagielski" <jim@jaguNET.com>
To: dev@httpd.apache.org
Sent: Tuesday, May 1, 2012 8:43:46 PM
Subject: Re: httpd 2.4.2 - mod_proxy id name not unique

Let me look into that... iirc, it was due to us wanting to
be able to persist data between restarts and using the time
as part of the id prevented that. But I could be mis-remembering.

On Apr 30, 2012, at 7:50 AM, Zisis Lianas wrote:

> hi,
> 
> when mod_proxy currently is generating his "id", the name
> of this id is not very unique. So if you have a shared config/
> logs dir for more instances, the slotmem-shm files generated in
> DefaultRuntimeDir are the same. Bit unlucky if working with shared
> file systems.
> 
> In httpd-2.4.2/modules/proxy/mod_proxy.c line 1146 I can see
> the following code:
> #if 0
>    id = ap_proxy_hashfunc(apr_psprintf(p, "%pp-%" APR_TIME_T_FMT, ps, apr_time_now()),
PROXY_HASHFUNC_DEFAULT);
> #else
>    id = ap_proxy_hashfunc(apr_psprintf(p, "%pp", ps), PROXY_HASHFUNC_DEFAULT);
> #endif
> 
> Primarily checked in with
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.c?r1=1065749&r2=1065748&pathrev=1065749
> 
> 
> If activating the first ap_proxy_hashfunc call, the generated names
> seem to be unique. Is there any reason this code is not used? Maybe
> we can set the "timed" version as default?
> 
> 
> 
> best regards,
> Zisis
> 


Mime
View raw message