Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A80BECD8E for ; Fri, 27 Apr 2012 05:56:20 +0000 (UTC) Received: (qmail 5376 invoked by uid 500); 27 Apr 2012 05:56:19 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 5241 invoked by uid 500); 27 Apr 2012 05:56:16 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 5204 invoked by uid 99); 27 Apr 2012 05:56:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Apr 2012 05:56:15 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of margol@beamartyr.net designates 85.195.98.136 as permitted sender) Received: from [85.195.98.136] (HELO zaphod.mirimar.net) (85.195.98.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Apr 2012 05:56:07 +0000 Received: from [192.168.3.124] (dynamic-213-57-144-248.hotnet.net.il [213.57.144.248] (may be forged)) (authenticated bits=0) by mail1.mirimar.net (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id q3R5tbT3000709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 27 Apr 2012 07:55:39 +0200 Message-ID: <4F9A34CA.2000902@beamartyr.net> Date: Fri, 27 Apr 2012 08:55:22 +0300 From: Issac Goldstand User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: packaging libapreq2 as a dependency References: <1335492759.77968.YahooMailNeo@web160901.mail.bf1.yahoo.com> In-Reply-To: <1335492759.77968.YahooMailNeo@web160901.mail.bf1.yahoo.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/alternative; boundary="------------020706060906000208000103" X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on zaphod.mirimar.net X-Virus-Scanned: clamav-milter 0.96.5 at zaphod X-Virus-Status: Clean X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,HELO_MISC_IP, HTML_MESSAGE,KHOP_DYNAMIC,RDNS_DYNAMIC autolearn=ham version=3.3.2 This is a multi-part message in MIME format. --------------020706060906000208000103 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 27/04/2012 05:12, Joe Schaefer wrote: > Now that some time has passed since Philip brought > apreq2 into trunk it's probably a good time to discuss > how best to incorporate it into httpd itself. Right > now the library files are in server/ which basically > means we're internally compiling libapreq2 into httpd. > > Personally I'd prefer to see libapreq2 bundled as an > upstream dependency, ie put the library into an associated > deps package or just something in srclib/ so it will > provide an independent library file (static, dynamic, or both) > so all users including httpd can link to that object. The > apreq devs spent a considerable amount of time writing > the apreq module api so people could use apreq in any > C context- within an httpd module, a CGI script, or an > fcgi daemon. It'd be nice to preserve that flexibility > going forward. > > Anyway I'm certainly willing to work on libapreq's build system > so it will not be dependent on apxs- it should be really easy > to do given that we just need apxs in a very limited way (basically > to get at the apr-*-config package scripts), I > just need to make the apache2 module build optional so just > the library gets built. That would entail pulling the apreq > source files out of server/ and just leaving the apreq2 > filter module as part of httpd's build system. > > +0 I'm +1 for splitting and putting apreq2 filter in the build system; it's what to do with libapreq2 that holds me back... I don't like the idea of "yet another library/dependency" for building httpd, but after thinking about it, I probably wouldn't want it as more clutter either in APR or in libhttpd either. I'd likely change that to a +1 on the whole if I had even a whisper of a rumor if anyone (other than the mod_perl folks) was planning on incorporating apreq into some existing software to justify it being a standalone library. I know we built for it, but I've yet to see real adoption. Issac --------------020706060906000208000103 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 27/04/2012 05:12, Joe Schaefer wrote:
Now that some time has passed since Philip brought
apreq2 into trunk it's probably a good time to discuss
how best to incorporate it into httpd itself.  Right
now the library files are in server/ which basically
means we're internally compiling libapreq2 into httpd.

Personally I'd prefer to see libapreq2 bundled as an
upstream dependency, ie put the library into an associated
deps package or just something in srclib/ so it will
provide an independent library file (static, dynamic, or both)
so all users including httpd can link to that object. The
apreq devs spent a considerable amount of time writing
the apreq module api so people could use apreq in any
C context- within an httpd module, a CGI script, or an
fcgi daemon.  It'd be nice to preserve that flexibility
going forward.

Anyway I'm certainly willing to work on libapreq's build system
so it will not be dependent on apxs- it should be really easy
to do given that we just need apxs in a very limited way (basically
to get at the apr-*-config package scripts), I
just need to make the apache2 module build optional so just
the library gets built.  That would entail pulling the apreq
source files out of server/ and just leaving the apreq2
filter module as part of httpd's build system.


+0

I'm +1 for splitting and putting apreq2 filter in the build system; it's what to do with libapreq2 that holds me back...

I don't like the idea of "yet another library/dependency" for building httpd, but after thinking about it, I probably wouldn't want it as more clutter either in APR or in libhttpd either.  I'd likely change that to a +1 on the whole if I had even a whisper of a rumor if anyone (other than the mod_perl folks) was planning on incorporating apreq into some existing software to justify it being a standalone library.  I know we built for it, but I've yet to see real adoption.

  Issac
--------------020706060906000208000103--