From dev-return-75162-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org Wed Apr 11 18:22:38 2012 Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD79F9563 for ; Wed, 11 Apr 2012 18:22:38 +0000 (UTC) Received: (qmail 41303 invoked by uid 500); 11 Apr 2012 18:22:37 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 41252 invoked by uid 500); 11 Apr 2012 18:22:37 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 41244 invoked by uid 99); 11 Apr 2012 18:22:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2012 18:22:37 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of i.galic@brainsware.org designates 188.40.115.121 as permitted sender) Received: from [188.40.115.121] (HELO mail.brainsware.org) (188.40.115.121) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2012 18:22:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.brainsware.org (Postfix) with ESMTP id 342D96C00F for ; Wed, 11 Apr 2012 18:22:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at brainsware.org Received: from mail.brainsware.org ([127.0.0.1]) by localhost (mail.brainsware.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tCH2PwQ5pflF for ; Wed, 11 Apr 2012 18:22:05 +0000 (UTC) Received: from mail.brainsware.org (mail.brainsware.org [188.40.115.121]) by mail.brainsware.org (Postfix) with ESMTP id 219F96C00B for ; Wed, 11 Apr 2012 18:22:05 +0000 (UTC) Date: Wed, 11 Apr 2012 18:22:05 -0000 (UTC) From: Igor =?utf-8?Q?Gali=C4=87?= To: "dev " Subject: [PATCH] mod_dbd multiple pools (pr#45456) Message-ID: <679515c7-968e-4b65-b709-f24d6ffcb1c3@iris> In-Reply-To: <674a0a0f-4e8c-4dd7-b904-9f4b1c96f1b0@iris> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Originating-IP: [91.130.91.125] X-Mailer: Zimbra 7.0.0_GA_3077 (ZimbraWebClient - FF3.0 (Linux)/7.0.0_GA_3077) Hi folks, I've updated Marko Kevac's patch to allow for multiple pools in mod_dbd. I'd like to ask for reviews and opinions in particular this here seems a bit odd: https://issues.apache.org/bugzilla/attachment.cgi?id=3D28585&action=3Ddif= f#modules/database/mod_dbd.c_sec20 It's in the nature of the patch that it breaks the API, and I've been wondering how we can handle that more gracefully. My first concern when starting out with the patchset was that I would break tests. Now my concern is that we don't have any. So another issue is: How do we test this module? Thanks, i -- Igor Gali=C4=87 Tel: +43 (0) 664 886 22 883 Mail: i.galic@brainsware.org URL: http://brainsware.org/ GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE