Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (athena.apache.org: 76.96.30.64 is neither permitted nor
 denied by domain of jim@jagunet.com)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1257)
Subject: Re: printing r->filename for access denied errors
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: 
 <CALK=YjP5ZBX=wti6rG-+ZYJb4WarmWFz9pq1iVWvm2fd-LfzWw@mail.gmail.com>
Date: Fri, 16 Mar 2012 08:54:02 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <BAB582A6-4E72-424F-8A7C-D55CE2A659B5@jaguNET.com>
References: 
 <CALK=YjP5ZBX=wti6rG-+ZYJb4WarmWFz9pq1iVWvm2fd-LfzWw@mail.gmail.com>
To: dev@httpd.apache.org

++1
On Mar 16, 2012, at 7:54 AM, Eric Covener wrote:

> Seems like IRC users are often confused that permission denied errors
> include the URI only and not the filesystem path.
>=20
> (They're convinced it's failing because httpd is looking in the wrong
> place for /index.html, or they think we forgot to add a documentroot,
> or have no idea where /foo/bar/baz is supposed to be in the
> filesystem)
>=20
> Is there any harm in adding it?  This is the rv from a stat in the
> directory walk.
>=20
> Index: server/request.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- server/request.c	(revision 1299737)
> +++ server/request.c	(working copy)
> @@ -1094,9 +1094,9 @@
>             }
>             else if (APR_STATUS_IS_EACCES(rv)) {
>                 ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, =
APLOGNO(00035)
> -                              "access to %s denied because search "
> -                              "permissions are missing on a component =
"
> -                              "of the path", r->uri);
> +                              "access to %s (filesystem path '%s') =
denied "
> +                              "because search permissions are missing =
on a "
> +                              "component of the path", r->uri, =
r->filename);
>                 return r->status =3D HTTP_FORBIDDEN;
>             }
>             else if ((rv !=3D APR_SUCCESS && rv !=3D APR_INCOMPLETE)
> @@ -1105,7 +1105,8 @@
>                  * rather than assume not found.
>                  */
>                 ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, =
APLOGNO(00036)
> -                              "access to %s failed", r->uri);
> +                              "access to %s (filesystem path '%s') =
failed",
> +                              r->uri, r->filename);
>                 return r->status =3D HTTP_FORBIDDEN;
>             }
>=20
>=20
> --=20
> Eric Covener
> covener@gmail.com
>=20