Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 995A89098 for ; Mon, 19 Mar 2012 14:31:38 +0000 (UTC) Received: (qmail 6260 invoked by uid 500); 19 Mar 2012 14:31:37 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 6179 invoked by uid 500); 19 Mar 2012 14:31:36 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 6165 invoked by uid 99); 19 Mar 2012 14:31:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2012 14:31:36 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 76.96.59.243 is neither permitted nor denied by domain of jim@jagunet.com) Received: from [76.96.59.243] (HELO qmta13.westchester.pa.mail.comcast.net) (76.96.59.243) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2012 14:31:26 +0000 Received: from omta20.westchester.pa.mail.comcast.net ([76.96.62.71]) by qmta13.westchester.pa.mail.comcast.net with comcast id nRr31i0011YDfWL5DSX6en; Mon, 19 Mar 2012 14:31:06 +0000 Received: from [192.168.199.10] ([69.251.91.46]) by omta20.westchester.pa.mail.comcast.net with comcast id nSX61i00f100q0d3gSX6pw; Mon, 19 Mar 2012 14:31:06 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1257) Subject: Re: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c From: Jim Jagielski In-Reply-To: <20120319135329.379772388860@eris.apache.org> Date: Mon, 19 Mar 2012 10:31:05 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <1EEE6575-9D76-4569-93BF-119674D95728@jaguNET.com> References: <20120319135329.379772388860@eris.apache.org> To: dev@httpd.apache.org X-Mailer: Apple Mail (2.1257) X-Virus-Checked: Checked by ClamAV on apache.org On Mar 19, 2012, at 9:53 AM, rpluem@apache.org wrote: > Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.c > URL: = http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.c?r= ev=3D1302444&r1=3D1302443&r2=3D1302444&view=3Ddiff > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- httpd/httpd/trunk/modules/proxy/mod_proxy.c (original) > +++ httpd/httpd/trunk/modules/proxy/mod_proxy.c Mon Mar 19 13:53:28 = 2012 > @@ -2461,11 +2461,11 @@ static void child_init(apr_pool_t *p, se > ap_proxy_hashfunc(reverse->s->name, = PROXY_HASHFUNC_FNV); > /* Do not disable worker in case of errors */ > reverse->s->status |=3D PROXY_WORKER_IGNORE_ERRORS; > - conf->reverse =3D reverse; > ap_proxy_initialize_worker(conf->reverse, s, conf->pool); > /* Disable address cache for generic reverse worker */ > reverse->s->is_address_reusable =3D 0; > } > + conf->reverse =3D reverse; > s =3D s->next; > } > } >=20 Is that right? Doesn't that mean that the ap_proxy_initialize_worker() call gets an unknown/undefined 1st arg (conf->reverse)??=