httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: svn commit: r1303435 - /httpd/httpd/trunk/server/mpm_unix.c
Date Thu, 22 Mar 2012 07:49:29 GMT


> -----Original Message-----
> From: Eric Covener 
> Sent: Mittwoch, 21. März 2012 18:58
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1303435 -
> /httpd/httpd/trunk/server/mpm_unix.c
> 
> > @@ -937,7 +937,7 @@ AP_DECLARE(apr_status_t) ap_fatal_signal
> >
> >  #endif /* NO_USE_SIGACTION */
> >
> > -    pconf = in_pconf;
> > +    pconf = pconf;
> >     parent_pid = my_pid = getpid();
> 
> Doesn't the parameter name need to be changed back?

IMHO not. The definition was synced with what we had in the header file.
Although this is not required from compiler perspective I prefer header and c file
in sync on the parameter names as well.

Regards

Rüdiger

Mime
View raw message