Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 856A991C6 for ; Tue, 28 Feb 2012 21:27:06 +0000 (UTC) Received: (qmail 19991 invoked by uid 500); 28 Feb 2012 21:27:05 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 19943 invoked by uid 500); 28 Feb 2012 21:27:05 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 19935 invoked by uid 99); 28 Feb 2012 21:27:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 21:27:05 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of trawick@gmail.com designates 209.85.212.45 as permitted sender) Received: from [209.85.212.45] (HELO mail-vw0-f45.google.com) (209.85.212.45) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 21:27:00 +0000 Received: by vbbfs19 with SMTP id fs19so2246971vbb.18 for ; Tue, 28 Feb 2012 13:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of trawick@gmail.com designates 10.52.20.78 as permitted sender) client-ip=10.52.20.78; Authentication-Results: mr.google.com; spf=pass (google.com: domain of trawick@gmail.com designates 10.52.20.78 as permitted sender) smtp.mail=trawick@gmail.com; dkim=pass header.i=trawick@gmail.com Received: from mr.google.com ([10.52.20.78]) by 10.52.20.78 with SMTP id l14mr16116764vde.62.1330464399766 (num_hops = 1); Tue, 28 Feb 2012 13:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=ALF6AwItfkbrICz85P9g2d8e5g0VQ15v6mcYJRbL7gs=; b=DNRYL5a3yYA3T8/6zvRl79CY9Ng54mSa/sq4U1Aa3ZdeEnS7mmfUXJcLS/BGZdHOK2 fkD9/3p88DmU4uSH6z8bp3WmyOMIKVIUcOTw3ftBDBjGpSBPMPdjQGYX1lZOG8RzSSs4 RcsecCdllBX/tpjAV28ZuyxAK9hZUExhNO8kc= MIME-Version: 1.0 Received: by 10.52.20.78 with SMTP id l14mr13290394vde.62.1330464399704; Tue, 28 Feb 2012 13:26:39 -0800 (PST) Received: by 10.220.192.69 with HTTP; Tue, 28 Feb 2012 13:26:39 -0800 (PST) In-Reply-To: References: <20120227225719.A87BD2388900@eris.apache.org> Date: Tue, 28 Feb 2012 16:26:39 -0500 Message-ID: Subject: Re: svn commit: r1294380 - in /httpd/httpd/branches/2.2.x: build/aix/ build/aix/README build/aix/aixinfo build/aix/buildaix.ksh build/aix/mkinstallp.ksh config.layout From: Jeff Trawick To: dev@httpd.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Feb 28, 2012 at 3:06 PM, Graham Leggett wrote: > On 28 Feb 2012, at 3:48 PM, Jeff Trawick wrote: > >> Is this really ready? =A0The trunk version (if even tested on trunk) at >> best barely works, and this hasn't seen many eyes. > > I don't have access to an AIX machine, so can only rely on Michael's judg= ement for this. Given that we aren't awash with AIX expertise, we need to p= ut some trust in the person doing the packaging, the same as we do for Netw= are and other similar platforms. FWLIW, others on the list have access. >> Has the packaging of dependent libraries been figured out? =A0Is there >> really a such thing as =A0"ASF.apu.rte and ASF.apr.rte filesets"? >> Is it appropriate that a package built by a random user is labeled as >> an "ASF" package, as if the ASF created it? > > I don't see why labeling it "ASF" is a problem. Anyone building the packa= ge would be doing so by following a formal procedure codified in the build = script, which is in turn published by the ASF, as opposed some vendor's bui= ld script. Maybe this info would help... I dunno. This really is project-only scope we're managing, not ASF-wide scope. Either there is coordination among different projects, or it shouldn't look like there is. http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=3D/co= m.ibm.aix.genprogc/doc/genprogc/pkging_sw4_install.htm > >> Is it appropriate to instruct users that in some cases they should >> "add symbolic links from /usr/include to /opt/include"? > > It looks like zlib isn't necessarily available as a proper package. Given= we don't ship zlib, but depend on it, if the platform has certain limitati= ons regarding the availability of certain dependencies, we would need to wo= rk around that. It doesn't sound like the right technical solution to me. CPPFLAGS? > >> What about the todos regarding copyrights and licenses? > > What specifically about them? The todo file you committed says that verbatim ;) What are they, and why can't they be resolved before committing? > From what I can see, AIX packages offer the option to force the end user = to accept a license before installing a package, and there is an open quest= ion as to whether we do this or not. We don't do it for RPM (nor does RPM l= et you do this), I see no reason to mandate doing it here. License acceptance is one thing. I dunno what the copyright issue is. > >> What about the trivial issue of hard-coding the version? =A0(search for >> "2.2.22") =A0Presumably the real version is figured out later, but why >> is this in there? > > A mistake perhaps? > > Looks like VERSION is defined twice, once hard coded, and then a second t= ime properly. Solution seems to be to remove the first attempt to set VERSI= ON. > >> Committing to trunk is one thing, but IMO before moving to stable >> branches, especially 2.2.x, this needs careful review by at minimum >> someone who is very familiar with AIX and will test it personally, and >> hopefully by others who will ask the necessary questions to understand >> the ramifications, and not end up having to repair the thing in >> 2.2.(n+5)/2.4.(n+5) and break compatibility with previous versions. >> >> Hats off to Michael for working on this, but this contains a lot of >> gory details to consider, and AFAIK no one who has logged onto an AIX >> box since mid-2008 has stared at it enough to identify even the most >> trivial of issues. > > The build for v2.2.x will look nothing like the build for v2.4.x, and for= this reason there is no way to apply changes to trunk, and then backport i= t, as each branch works completely differently, and therefore the build wil= l work completely differently. > > If this is too much of a pain, working from a branch might be a better id= ea until these issues are solved. > > Regards, > Graham > -- > --=20 Born in Roswell... married an alien...