httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: mod_slotmem and mod_proxy_balancer/others on win32 (PR52402)
Date Fri, 03 Feb 2012 13:45:13 GMT

On Feb 3, 2012, at 8:03 AM, Mladen Turk wrote:
> 
> Right, seems that's not the reason for PR52402.
> Found the fix for it. The reason is the loop:
> 
>    while (s) {
>        int i,j;
>        proxy_balancer *balancer;
>        sconf = s->module_config;
>        conf = (proxy_server_conf *)ap_get_module_config(sconf, &proxy_module);
> 
>        /* adding ... */
>        if (conf->bslot) {
>            /* We already have shared memory storage created for this server_rec.
>             * Skip second invocation because there are no more space left in
>             * the shm so the storage->grab() will fail.
>             */
>            s = s->next;
>            continue;
>        }
>        ....
> 
> Fixes the issue, although I'm not sure that's the correct solution.
> Shared memory id uses vhost name for key, and think it should use
> vhost:port combination instead.
> 
> However I might be wrong and the upper patch is all that's needed
> if the balancer is shared between multiple server_rec's

THANKS! Let me look into this more... at 1st blush, the suggestion
of vhost:port makes sense... maybe even scheme:vhost:port.
Mime
View raw message