httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregg Smith <...@gknw.net>
Subject Re: [PATCH] trunk/2.4 core output filter is broken
Date Sat, 04 Feb 2012 06:11:31 GMT
On 2/3/2012 10:43 AM, Stefan Fritsch wrote:
> On Thursday 02 February 2012, William A. Rowe Jr. wrote:
>> On 2/2/2012 8:36 AM, Jim Jagielski wrote:
>>> bb == NULL ??
>> Looking at his attached screen scrape; no.  Which leaves with
>> something like e == NULL or a broken bb.
> The former :-(
>
> Gregg, please add this or try the attached patch which is against
> current trunk and includes all fixes so far. Thanks in advance.
>
> --- a/server/mpm/winnt/child.c
> +++ b/server/mpm/winnt/child.c
> @@ -743,11 +743,10 @@ apr_status_t
> winnt_insert_network_bucket(conn_rec *c,
>       apr_bucket *e;
>       winnt_conn_ctx_t *context = ap_get_module_config(c->conn_config,
>                                                        &mpm_winnt_module);
> -    if (context == NULL)
> +    if (context == NULL || (e = context->overlapped.Pointer) == NULL)
>           return DECLINED;
>
>       /* seed the brigade with AcceptEx read heap bucket */
> -    e = context->overlapped.Pointer;
>       APR_BRIGADE_INSERT_HEAD(bb, e);
>       /* also seed the brigade with the client socket. */
>       e = apr_bucket_socket_create(socket, c->bucket_alloc);

Stefan,

This fixes the crash, thanks.




Mime
View raw message