httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] trunk/2.4 core output filter is broken
Date Thu, 02 Feb 2012 15:58:17 GMT
On Sun, Jan 29, 2012 at 08:53:09PM +0100, Stefan Fritsch wrote:
> + * Insert the network bucket into the core input filter's input brigade.
> + * This hook is intended for MPMs or protocol modules that need to do special
> + * socket setup.
> + * @param c The connection
> + * @param bb The brigade to insert the bucket into
> + * @param socket The socket to put into a bucket
> + * @return DECLINED if the current function does not handle this connection,
> + *         APR_SUCCESS or an error otherwise.
> + */
> +AP_DECLARE_HOOK(apr_status_t, insert_network_bucket,
> +                (conn_rec *c, apr_bucket_brigade *bb, apr_socket_t *socket))

The combination of APR_SUCCESS and DECLINED is unusual; an int return 
value with OK/DECLINED? Looks great otherwise - thanks Stefan!

Mime
View raw message