Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (athena.apache.org: 76.96.27.211 is neither permitted
 nor denied by domain of jim@jagunet.com)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1251.1)
Subject: Re: [PATCH] trunk/2.4 core output filter is broken
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: <201201292053.09488.sf@sfritsch.de>
Date: Mon, 30 Jan 2012 08:57:43 -0500
Content-Transfer-Encoding: 7bit
Message-Id: <7746FB2F-AAB4-4AC4-BF5B-4B9E2852E6F6@jaguNET.com>
References: <20120120165210.GA23839@redhat.com>
 <alpine.DEB.2.00.1201242156420.26838@eru.sfritsch.de>
 <994D9463-41EA-43B1-BAFA-61BA170D95B2@jaguNET.com>
 <201201292053.09488.sf@sfritsch.de>
To: dev@httpd.apache.org


On Jan 29, 2012, at 2:53 PM, Stefan Fritsch wrote:

> On Wednesday 25 January 2012, Jim Jagielski wrote:
>> Looking over the code, impl as a hook seems more "isolated",
>> rather than the current impl which is intrusive (which is
>> part of what we're trying to avoid, aren't we?)
> 
> OK, patch is attached. This needs review/testing for Windows.
> <insert_network_bucket.diff>

Just a quick scan but:

  +AP_IMPLEMENT_HOOK_RUN_FIRST(apr_status_t, insert_network_bucket,
  +                            (conn_rec *c, apr_bucket_brigade *bb,
  +                             apr_socket_t *socket),
  +                            (c, bb, socket), DECLINED)
  +
  ...
  +    ap_hook_insert_network_bucket(core_insert_network_bucket, NULL, NULL,
  +                                  APR_HOOK_REALLY_LAST);

looks wonky...