httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: Questions on open ports between trunk and 2.4.x
Date Tue, 31 Jan 2012 16:38:38 GMT
Thx for digging into this!

On Jan 31, 2012, at 10:07 AM, Rainer Jung wrote:

> I backported some trunk changes to 2.4.x (mostly cosmetic ones) and a few changes also
in the other direction to keep code changes small in parts were there are still no functional
changes.
> 
> A few backports are open, because I'm not sure, whether we want to backport. I left out
the obvious changes (serf, apreq and similar), and also the changes related to the recent
core filter improvements, but the below ones are not obvious to me. Comments on them welcome:
> 
> 1) mod_reqtimeout
> =================
> 
> r1202255 | pquerna | 2011-11-15 16:49:19 +0100 (Tue, 15 Nov 2011) | 1 line
> disable mod_reqtimeout if not configured
> 
> It looks like mod_reqtimeout is now inactive by default in trunk, but ses some builtin
default values in 2.4.x. Is that what we want? I'd expected that if we have it automatically
use default values when loaded in 2.4.x, we would want the same behaviour in trunk.
> 

I'd prefer we keep the 2.4 behavior, but am happy with any.
> 
> 2) log tags
> ===========
> 
> r1209743 | sf | 2011-12-02 23:26:54 +0100 (Fri, 02 Dec 2011) | 3 lines
> Add APLOGNO() macro for unique tags for every log message.
> Add some scripts to make adding these tags easier.
> 
> This has only been backported partially. The directory docs/log-message-tags is mising
in 2.4.x as well as the update-log-tags and update-log-msg-tags targets in Makefile.
> 
> 

Ugg... +1 on these

> 4) mod_proxy_html
> =================
> 
> r1200556 | jorton | 2011-11-10 22:21:03 +0100 (Thu, 10 Nov 2011) | 3 lines
> 
> * modules/filters/mod_proxy_html.c: Fix various code style issues.  Use
>  apr_is* ctype macro wrappers.
> 
> 
> I guess we want that also in 2.4.x.
> 

+1

> 
> 5) mod_authnz_ldap
> ==================
> 
> r1231257 | covener | 2012-01-13 20:18:03 +0100 (Fri, 13 Jan 2012) | 3 lines
> 
> whitespace only: shift a block refactored in r1231255 over 8 spaces.
> 
> 
> r1231255 | covener | 2012-01-13 20:16:50 +0100 (Fri, 13 Jan 2012) | 5 lines
> 
>  *) mod_authnz_ldap: Don't try a potentially expensive nested groups
>     search before exhausting all AuthLDAPGroupAttribute checks on the
>     current group. PR52464
> 

Is it applicable?

> 7) .htaccess handling
> =====================
> 
> ------------------------------------------------------------------------
> r1229021 | niq | 2012-01-09 05:01:06 +0100 (Mon, 09 Jan 2012) | 5 lines
> 
> Core configuration: add AllowOverride option to treat syntax
> errors in .htaccess as non-fatal.
> PR 52439
> 
> 
+1



Mime
View raw message