httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: Fwd: [users@httpd] Invalid URI in request OPTIONS * HTTP/1.0
Date Fri, 06 Jan 2012 15:33:32 GMT
On Fri, Jan 6, 2012 at 10:02 AM, Ruediger Pluem <rpluem@apache.org> wrote:
>
>
> Eric Covener wrote:
>> On Fri, Jan 6, 2012 at 9:46 AM, Ruediger Pluem <rpluem@apache.org> wrote:
>>>
>>>
>>> Eric Covener wrote:
>>>> Looks like SuSE backported the trunk fix which misfires on the
>>>> internally dummy conn.
>>>>
>>>> STATUS says we were thinking of flipping this to declined.  Looks like
>>>> a good idea?
>>>
>>> Could you please provide some more pointers?
>>
>>
>> I assume SuSe backported our trunk solution inside of mod_rewrite and
>> mod_proxy, which is proposed for 2.2.x
>
> But the trunk code looks like
>
>
> Index: mod_rewrite.c
> ===================================================================
> --- mod_rewrite.c       (revision 1209431)
> +++ mod_rewrite.c       (revision 1209432)
> @@ -4419,6 +4419,18 @@
>         return DECLINED;
>     }
>
> +    if (strcmp(r->unparsed_uri, "*") == 0) {
> +        /* Don't apply rewrite rules to "*". */
> +        return DECLINED;
> +    }
> +
> +    /* Check that the URI is valid. */
> +    if (!r->uri || r->uri[0] != '/') {
> +        ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
> +                     "Invalid URI in request %s", r->the_request);
> +        return HTTP_BAD_REQUEST;
> +    }
> +
>     /*
>      *  add the SCRIPT_URL variable to the env. this is a bit complicated
>      *  due to the fact that apache uses subrequests and internal redirects
>
>
> So IMHO this error should not happen as I assume that the value of r->unparsed_uri
should be "*" in this case.
>

Whoops, I zoomed in on the 2nd block only.

Mime
View raw message