httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@links.org>
Subject Re: Style violations
Date Sun, 08 Jan 2012 16:57:26 GMT
On Sun, Jan 8, 2012 at 4:20 PM, Jim Jagielski <jim@jagunet.com> wrote:
> How much is "entirely"?
>
> Do the >80char lines in ap_listen.h, ap_mmn.h, ap_mpm.h, ap_provider.h,
> ap_regex.h, ap_regkey.h, ap_slotmem.h, http_core.h, http_protocol,h,
> etc etc etc etc also constitute a rating of "entirely"?
>
> I'd look for more, but my time is better spent fixing things that
> I find need-to-be-fixed rather than just pointing them out...

Was tempted to comment first time round - if Bill objects, why does he
not just commit a fix?

Not _quite_ as irritating as the demands I used to resist on a regular
basis to fix bugs in my commits on platforms I did not have access to,
but getting up there.

>
> On Jan 5, 2012, at 4:56 PM, William A. Rowe Jr. wrote:
>
>> modules\proxy\mod_proxy.h entirely violates our 80 column rule,
>> which is particularly offensive owing to the fact that the .h
>> files are the easiest reference outside of doxygen for developers
>> to become familiar with httpd entry points, and aught to be not
>> only editable, but also printable.
>>
>> Would the culprits please clean up before the next 2.4 tag?
>>
>

Mime
View raw message