httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: [PATCH] trunk/2.4 core output filter is broken
Date Tue, 31 Jan 2012 16:03:27 GMT
Hi Stefan,

On 29.01.2012 20:53, Stefan Fritsch wrote:
> On Wednesday 25 January 2012, Jim Jagielski wrote:
>> Looking over the code, impl as a hook seems more "isolated",
>> rather than the current impl which is intrusive (which is
>> part of what we're trying to avoid, aren't we?)
>
> OK, patch is attached. This needs review/testing for Windows.

as far as I understand, this patch is for trunk.
Testing against 2.4.x would in addition need to first apply the 
following four patches (all the trunk commits apply clean to 2.4.x):

------------------------------------------------------------------------
r1236122 | rpluem | 2012-01-26 11:03:36 +0100 (Thu, 26 Jan 2012) | 1 line

* Don't typedef twice (in .c and .h file).
------------------------------------------------------------------------
r1233882 | jorton | 2012-01-20 13:41:18 +0100 (Fri, 20 Jan 2012) | 4 lines

* server/core_filters.c (ap_core_input_filter): Only treat EAGAIN as
   success if a non-blocking read was requested; for a blocking read,
   it is an error condition.

------------------------------------------------------------------------
r1234899 | jorton | 2012-01-23 17:57:07 +0100 (Mon, 23 Jan 2012) | 4 lines

* server/core_filters.c (send_brigade_nonblocking): Use a non-blocking
   bucket read, allowing any pending data to be flushed before trying a
   (potentially slow) blocking read.

------------------------------------------------------------------------
r1235019 | sf | 2012-01-23 22:58:42 +0100 (Mon, 23 Jan 2012) | 6 lines

Make the core input/output filter contexts private and provide accessor APIs
for mpm_winnt and mod_ftp.

This allows to add members to the context structs without breaking binary
compatibility.

------------------------------------------------------------------------

Is that your understanding as well? Or are some of those unwanted for 2.4.x?

Regards,

Rainer

Mime
View raw message