httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <>
Subject Re: 2.2.22
Date Mon, 23 Jan 2012 11:35:14 GMT
On 23 Jan 2012, at 6:13 AM, William A. Rowe Jr. wrote:

>> Seems to me that there's enough to warrant a 2.2.22 release...
>> As long as we're doing a 2.4.1, why not also provide a 2.2.22
>> at the same time?
> Because, 2.4.x is a distraction to shipping 2.2.22.  You are
> welcome to do a 2.4.x, although I will vote against it without
> sensible include/includeoptional behavior, or without a sensible
> non-DoSing core filter, or without the correction of sometimes
> faulty acceptfilter none/mod_ssl behavior on win32.

The Include/IncludeOptional stuff is your code, instead of voting against your own code, fix
it instead:

Little-Net:httpd-trunk minfrin$ svn log -c 931435
r931435 | wrowe | 2010-04-07 06:51:46 +0200 (Wed, 07 Apr 2010) | 6 lines

First order simplification; Add IncludeOptional for introducing
wildcard pattern matches or specific includes which may be omitted.
Refactors ap_process_resource_config() to deal efficiently with 
a single file, and renames the new _ex() flavor per list discussion
to  ap_process_fnmatch_configs() for wildcard processing.

931435      wrowe AP_INIT_TAKE1("Include", include_config, NULL,
 88449        rbb   (RSRC_CONF | ACCESS_CONF | EXEC_ON_READ),
931435      wrowe   "Name(s) of the config file(s) to be included; fails if the wildcard does
931435      wrowe   "not match at least one file"),
931435      wrowe AP_INIT_TAKE1("IncludeOptional", include_config, (void*)1,
931435      wrowe   (RSRC_CONF | ACCESS_CONF | EXEC_ON_READ),
931435      wrowe   "Name or pattern of the config file(s) to be included; ignored if the
file "
931435      wrowe   "does not exist or the pattern does not match any files"),

It should not have fallen on sf to have to document this change.

People who commit code are responsible for ensuring any documentation that concerns their
code is both present and accurate.


View raw message