httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: trunk/2.4 core output filter is broken
Date Mon, 23 Jan 2012 16:00:34 GMT
On Monday 23 January 2012, William A. Rowe Jr. wrote:
> On 1/22/2012 10:34 PM, William A. Rowe Jr. wrote:
> > On 1/22/2012 5:12 AM, Stefan Fritsch wrote:
> >> On Friday 20 January 2012, Joe Orton wrote:
> >>> Good catch on ctx->bytes_in. I'd add: why is
> >>> core_output_filter_ctx_t in a public header?
> >> 
> >> There is no good reason other than that other core filter
> >> structs like core_filter_ctx and core_net_rec are exposed, too.
> >> And those are actually used by the winnt MPM. I would prefer if
> >> all these structs were private and core_filters.c would provide
> >> an API to allocate them from the winnt MPM and add additional
> >> buckets to the input brigade. Is this something we should still
> >> do for 2.4.x (iff 2.4.0 is not released)?
> > 
> > See also my observations about
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=52476
> 
> And before you make them private, look at other protocol modules
> such as mod_ftp.  Losing these entirely would be foolish. 
> Plugging into it could be made simpler, yes.

Good point. mod_ftp does exactly the same as the winnt MPM. I couldn't 
find any other module that needs access to the core filter contexts.

Mime
View raw message