httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: [PATCH] mod_mbox: show list name in the <h1/>
Date Mon, 02 Jan 2012 19:07:30 GMT
On Monday 02 January 2012, Daniel Shahaf wrote:
> Henri Yandell (Created) (JIRA) wrote on Wed, Dec 21, 2011 at 
06:03:30 +0000:
> > Note list name on mail detail page
> > ----------------------------------
> > 
> >                  Key: INFRA-4238
> >                  URL:
> >                  https://issues.apache.org/jira/browse/INFRA-423
> >                  8
> >              
> >              Project: Infrastructure
> >           
> >           Issue Type: Improvement
> >       
> >       Security Level: public (Regular issues)
> >       
> >             Reporter: Henri Yandell
> >             Priority: Minor
> > 
> > Looking at
> > http://mail-archives.apache.org/mod_mbox/www-infrastructure-dev/2
> > 01112.mbox/%3CA603FFCE-623B-43E9-87F8-39BAA51C72D1@gbiv.com%3E -
> > it would be nice to know what mailing list the email is to in
> > the UI. Currently you have to infer it from links or the url.
> > 
> > Having it as some kind of title would be good. Possibly it could
> > replace the 'list index' text for the link to the emails for that
> > mailing list.
> 
> [[[
> Tweak <h1/> title in the message display screen, for INFRA-4238.
> 
> Patch by: danielsh
> 
> * module-2.0/mod_mbox_out.c
>   (mbox_ajax_browser, mbox_static_browser):
>     Include the directory's basename in the title.
> ]]]

Hi Daniel,

I have done some work on mod_mbox last week which I have committed 
now. It includes displaying the list name in <h1> and <title> tags, 
though implemented slightly differently than your patch. This and some 
more code cleanup is now in trunk. This code should still work with 
2.2

In the new convert-charsets branch, I have committed some work to 
actually convert mail bodies, subject and from lines to UTF-8. This 
should take care of a load of displaying problems with various mails.
I have tested it with Firefox 9, Chrome, and KDE Konqueror 4.6.
There are two caveats, though: It adds a field to the cache files. 
This means that all mbox cache files need to be re-created. And it 
depends on HTTPD 2.3.x functionality.

It would of course be very nice if you could test the code from the 
branch, but doing the re-indexing is of course more work. Maybe you 
could pull some tricks with ZFS snapshots to allow for a fall-back 
path.

Cheers,
Stefan

Mime
View raw message