Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EB53F70DF for ; Tue, 27 Dec 2011 13:37:22 +0000 (UTC) Received: (qmail 1124 invoked by uid 500); 27 Dec 2011 13:37:22 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 1061 invoked by uid 500); 27 Dec 2011 13:37:22 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 1053 invoked by uid 99); 27 Dec 2011 13:37:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2011 13:37:22 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_FRT_SLUT X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of mamfelt@gmail.com designates 74.125.82.41 as permitted sender) Received: from [74.125.82.41] (HELO mail-ww0-f41.google.com) (74.125.82.41) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2011 13:37:13 +0000 Received: by wgbdt12 with SMTP id dt12so18218189wgb.0 for ; Tue, 27 Dec 2011 05:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=35w02BihgOtJ2xTolBAd1ddejubCIg19np8bDEUflZA=; b=CpclVC4kYdJqczaDoGmNzNlfaJ9Qw1aY9CfqkBf4wD+PlOJuCBo8MlbsJVP7gWW/9p N3W9SSQQCtX72KqbGAGbjrmA1NiX4zJ0cSlEzASSewBjpKNHBlYo+y+5MT/78BQTFnCG 7r6imxAzUuD7hO1bZJblvRe7j+AMLGPX4Al2Y= MIME-Version: 1.0 Received: by 10.216.131.106 with SMTP id l84mr15684895wei.29.1324993013634; Tue, 27 Dec 2011 05:36:53 -0800 (PST) Received: by 10.227.61.133 with HTTP; Tue, 27 Dec 2011 05:36:53 -0800 (PST) Date: Tue, 27 Dec 2011 14:36:53 +0100 Message-ID: Subject: when is an issue not a bug, but still needs some love... -- or -- should it be reported as a bug anyway? From: Michael Felt To: dev@httpd.apache.org Content-Type: multipart/alternative; boundary=001636c5a4cee8570204b512f9c3 X-Virus-Checked: Checked by ClamAV on apache.org --001636c5a4cee8570204b512f9c3 Content-Type: text/plain; charset=ISO-8859-1 Hello, just finished a configure and a make of httpd-2.3.16-beta. Went fairly smoothly - the issue that required some editting was with some #if #else #endif statements in modules/ssl/ssl_engine_init.c and modules/ssl/ssl_engine_kernel.c Basically, the IBM xlC (V7) compiler does not like #if constructs in the middle of a function call (or macro?). Diff of the original and my changes that compiled is: diff httpd-2.3.16-beta/modules/ssl/ssl_engine_init.c httpd-2.3.16a/modules/ssl/ssl_engine_init.c 1104d1103 < ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(01910) 1106c1105,1107 < "Oops, no RSA, DSA or ECC server certificate found " --- > ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(01910) > "Oops, no RSA, DSA or ECC server certificate found " > "for '%s:%d'?!", s->server_hostname, s->port); 1108,1109c1109,1110 < "Oops, no RSA or DSA server certificate found " < #endif --- > ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(01910) > "Oops, no RSA or DSA server certificate found " 1110a1112 > #endif 1129d1130 < ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(01911) 1130a1132 > ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(01911) 1132a1135 > ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(01911) 1430d1432 < ap_log_error(APLOG_MARK, 1431a1434 > ap_log_error(APLOG_MARK, 1433,1435d1435 < #else < APLOG_DEBUG, < #endif 1438d1437 < #ifdef OPENSSL_NO_TLSEXT 1439a1439,1445 > "%s (%s:%d) vs. %s (%s:%d)", > ssl_util_vhostid(p, s), > (s->defn_name ? s->defn_name : "unknown"), > s->defn_line_number, > ssl_util_vhostid(p, ps), > (ps->defn_name ? ps->defn_name : "unknown"), > ps->defn_line_number); 1440a1447,1450 > ap_log_error(APLOG_MARK, > APLOG_DEBUG, > 0, > base_server, 1442d1451 < #endif 1449a1459 > #endif 1458d1467 < ap_log_error(APLOG_MARK, APLOG_WARNING, 0, base_server, APLOGNO(01917) 1459a1469 > ap_log_error(APLOG_MARK, APLOG_WARNING, 0, base_server, APLOGNO(01917) 1462a1473 > ap_log_error(APLOG_MARK, APLOG_WARNING, 0, base_server, APLOGNO(01917) Only in httpd-2.3.16a/modules/ssl: ssl_engine_init.lo Only in httpd-2.3.16a/modules/ssl: ssl_engine_init.o Only in httpd-2.3.16a/modules/ssl: ssl_engine_init.slo Only in httpd-2.3.16a/modules/ssl: ssl_engine_io.lo Only in httpd-2.3.16a/modules/ssl: ssl_engine_io.o Only in httpd-2.3.16a/modules/ssl: ssl_engine_io.slo diff httpd-2.3.16-beta/modules/ssl/ssl_engine_kernel.c httpd-2.3.16a/modules/ssl/ssl_engine_kernel.c 767a768 > #if defined(SSL_get_secure_renegotiation_support) 771d771 < #if defined(SSL_get_secure_renegotiation_support) 773c773 < "client does" : "client does not" --- > "client does" : "client does not"); 775c775,778 < "server does not" --- > ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02260) > "Performing full renegotiation: complete handshake " > "protocol (%s support secure renegotiation)", > "server does not"); 777d779 < ); p.s. - As this is not really a "bug", but a compiler mismatch - should I post it as a bug, or is this enough (learning howto 'discuss' - I intend to use your answer as model for the future). regards, Michael --001636c5a4cee8570204b512f9c3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello,

just finished a configure and a make of httpd-2.3.16-beta. We= nt fairly smoothly - the issue that required some editting was with some #i= f #else #endif statements in modules/ssl/ssl_engine_init.c and modules/ssl/= ssl_engine_kernel.c

Basically, the IBM xlC (V7) compiler does not like #if constructs in th= e middle of a function call (or macro?).

Diff of the original and my= changes that compiled is:
diff htt= pd-2.3.16-beta/modules/ssl/ssl_engine_init.c httpd-2.3.16a/modules/ssl/ssl_= engine_init.c
1104d1103
<=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK, APLOG_EM= ERG, 0, s, APLOGNO(01910)
1106c1105,1107
<=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 "Oops, no RSA, DSA or ECC server certificate = found "
---
>=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK= , APLOG_EMERG, 0, s, APLOGNO(01910)
>=A0=A0=A0=A0=A0=A0 "Oops, no RSA, DSA or ECC server certificate fo= und "
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 "fo= r '%s:%d'?!", s->server_hostname, s->port);
1108,1109= c1109,1110
<=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 "Oo= ps, no RSA or DSA server certificate found "
< #endif
---
>=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK,= APLOG_EMERG, 0, s, APLOGNO(01910)
>=A0=A0=A0=A0=A0=A0 "Oops, n= o RSA or DSA server certificate found "
1110a1112
> #endif1129d1130
<=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK, APLOG_E= MERG, 0, s, APLOGNO(01911)
1130a1132
>=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK, APLOG_EM= ERG, 0, s, APLOGNO(01911)
1132a1135
>=A0=A0=A0=A0=A0=A0=A0=A0 ap_l= og_error(APLOG_MARK, APLOG_EMERG, 0, s, APLOGNO(01911)
1430d1432
<= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK,
1431a1434
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MA= RK,
1433,1435d1435
< #else
<=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 APLOG_DEBUG,
< #endif1438d1437
< #ifdef OPENSSL_NO_TLSEXT
1439a1439,1445
>=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &q= uot;%s (%s:%d) vs. %s (%s:%d)",
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 ssl_util_vhostid(p, s),
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (s->defn_name ? s->defn_name = : "unknown"),
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 s->defn_line_number,
>=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ssl_util= _vhostid(p, ps),
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 (ps->defn_name ? ps->defn_name : "unknown"),
>= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= ps->defn_line_number);
1440a1447,1450
>=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK,
>=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 APLOG_DEBUG,
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 0,
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 base_server,
1442d1451
< #endif
1449a1459> #endif
1458d1467
<=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLO= G_MARK, APLOG_WARNING, 0, base_server, APLOGNO(01917)
1459a1469
>=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_error(APLOG_MARK, APLOG_WA= RNING, 0, base_server, APLOGNO(01917)
1462a1473
>=A0=A0=A0=A0=A0= =A0=A0=A0 ap_log_error(APLOG_MARK, APLOG_WARNING, 0, base_server, APLOGNO(0= 1917)
Only in httpd-2.3.16a/modules/ssl: ssl_engine_init.lo
Only in httpd-2.3.16a/modules/ssl: ssl_engine_init.o
Only in httpd-2.3.1= 6a/modules/ssl: ssl_engine_init.slo
Only in httpd-2.3.16a/modules/ssl: s= sl_engine_io.lo
Only in httpd-2.3.16a/modules/ssl: ssl_engine_io.o
Only in httpd-2.3.16a/modules/ssl: ssl_engine_io.slo
diff httpd-2.3.16-b= eta/modules/ssl/ssl_engine_kernel.c httpd-2.3.16a/modules/ssl/ssl_engine_ke= rnel.c
767a768
> #if defined(SSL_get_secure_renegotiation_support)=
771d771
< #if defined(SSL_get_secure_renegotiation_support)
773c77= 3
<=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0 "client does" : "client does not"
--->=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 "client does" : "client does not");
775c775,778
<=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 "server does not"
---
>=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r,= APLOGNO(02260)
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 "Performing full renegotiation: complete h= andshake "
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 "protocol (%s support secure renegotiation)",
>= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 "server does not");
777d779
<=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 );

p.s. - As this is not really a "= bug", but a compiler mismatch - should I post it as a bug, or is this = enough (learning howto 'discuss' - I intend to use your answer as m= odel for the future).

regards,
Michael
--001636c5a4cee8570204b512f9c3--