Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <4EFB3875.2000601@vodafone.com>
Date: Wed, 28 Dec 2011 16:40:37 +0100
From: =?UTF-8?B?UsO8ZGlnZXIgUGzDvG0=?= <ruediger.pluem@vodafone.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de;
 rv:1.9.2.25) Gecko/20111216 SUSE/3.1.17 Thunderbird/3.1.17
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Fwd: svn commit: r1225199 - in /httpd/httpd/trunk:
 docs/log-message-tags/next-number
 server/core.c
Content-Type: multipart/alternative;
 boundary="------------040804040809000701030702"

This is a multi-part message in MIME format.
--------------040804040809000701030702
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


-------- Original-Nachricht --------
Betreff: 	svn commit: r1225199 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/core.c
Datum: 	Wed, 28 Dec 2011 14:54:50 GMT
Von: 	sf@apache.org


Author: sf
Date: Wed Dec 28 14:54:49 2011
New Revision: 1225199

URL: http://svn.apache.org/viewvc?rev=1225199&view=rev
Log:
Check during configtest that the directories for error logs exist

Testing under Windows is welcome

PR: 29941

Modified:
     httpd/httpd/trunk/docs/log-message-tags/next-number
     httpd/httpd/trunk/server/core.c


Modified: httpd/httpd/trunk/server/core.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/core.c?rev=1225199&r1=1225198&r2=1225199&view=diff
==============================================================================
--- httpd/httpd/trunk/server/core.c (original)
+++ httpd/httpd/trunk/server/core.c Wed Dec 28 14:54:49 2011
@@ -4342,6 +4342,44 @@ AP_DECLARE(int) ap_sys_privileges_handle
      return sys_privileges;
  }

+static int check_errorlog_dir(apr_pool_t *p, server_rec *s)
+{
+    if (s->error_fname[0] == '|'&&  strcmp(s->error_fname, "syslog") == 0)


Doesn't this need to be || instead of&&?

Regards

Rüdiger


--------------040804040809000701030702
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
    <title>svn commit: r1225199 - in /httpd/httpd/trunk:
      docs/log-message-tags/next-number server/core.c</title>
    <base
      href="http://mail-archives.apache.org/mod_mbox/httpd-cvs/?format=atom">
  </head>
  <body text="#000000" bgcolor="#ffffff">
    <br>
    <br>
    -------- Original-Nachricht --------
    <table class="moz-email-headers-table" border="0" cellpadding="0"
      cellspacing="0">
      <tbody>
        <tr>
          <th nowrap="nowrap" valign="BASELINE" align="RIGHT">Betreff: </th>
          <td>svn commit: r1225199 - in /httpd/httpd/trunk:
            docs/log-message-tags/next-number server/core.c</td>
        </tr>
        <tr>
          <th nowrap="nowrap" valign="BASELINE" align="RIGHT">Datum: </th>
          <td>Wed, 28 Dec 2011 14:54:50 GMT</td>
        </tr>
        <tr>
          <th nowrap="nowrap" valign="BASELINE" align="RIGHT">Von: </th>
          <td><a class="moz-txt-link-abbreviated" href="mailto:sf@apache.org">sf@apache.org</a></td>
        </tr>
      </tbody>
    </table>
    <br>
    <br>
    <title>svn commit: r1225199 - in /httpd/httpd/trunk:
      docs/log-message-tags/next-number server/core.c</title>
    <base
      href="http://mail-archives.apache.org/mod_mbox/httpd-cvs/?format=atom">
    <div xmlns="http://www.w3.org/1999/xhtml">
      <pre>Author: sf
Date: Wed Dec 28 14:54:49 2011
New Revision: 1225199

URL: <a class="moz-txt-link-freetext" href="http://svn.apache.org/viewvc?rev=1225199&amp;view=rev">http://svn.apache.org/viewvc?rev=1225199&amp;view=rev</a>
Log:
Check during configtest that the directories for error logs exist

Testing under Windows is welcome

PR: 29941 

Modified:
    httpd/httpd/trunk/docs/log-message-tags/next-number
    httpd/httpd/trunk/server/core.c


Modified: httpd/httpd/trunk/server/core.c
URL: <a class="moz-txt-link-freetext" href="http://svn.apache.org/viewvc/httpd/httpd/trunk/server/core.c?rev=1225199&amp;r1=1225198&amp;r2=1225199&amp;view=diff">http://svn.apache.org/viewvc/httpd/httpd/trunk/server/core.c?rev=1225199&amp;r1=1225198&amp;r2=1225199&amp;view=diff</a>
==============================================================================
--- httpd/httpd/trunk/server/core.c (original)
+++ httpd/httpd/trunk/server/core.c Wed Dec 28 14:54:49 2011
@@ -4342,6 +4342,44 @@ AP_DECLARE(int) ap_sys_privileges_handle
     return sys_privileges;
 }
 
+static int check_errorlog_dir(apr_pool_t *p, server_rec *s)
+{
+    if (s-&gt;error_fname[0] == '|' &amp;&amp; strcmp(s-&gt;error_fname, "syslog") == 0)


Doesn't this need to be || instead of &amp;&amp;?

Regards

Rüdiger


</pre>
    </div>
  </body>
</html>

--------------040804040809000701030702--