httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r1220867 - in /httpd/httpd/branches/2.4.x: ./ CHANGES Makefile.in build/rpm/httpd.spec.in build/rules.mk.in support/Makefile.in test/Makefile.in
Date Tue, 20 Dec 2011 07:34:15 GMT
On 12/19/2011 11:27 AM, minfrin@apache.org wrote:
> Modified: httpd/httpd/branches/2.4.x/Makefile.in
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/Makefile.in?rev=1220867&r1=1220866&r2=1220867&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/Makefile.in (original)
> +++ httpd/httpd/branches/2.4.x/Makefile.in Mon Dec 19 17:27:13 2011
> @@ -12,8 +12,8 @@ PROGRAM_DEPENDENCIES = \
>    $(MPM_LIB) \
>    os/$(OS_DIR)/libos.la
>  
> -PROGRAMS        = $(PROGRAM_NAME)
> -TARGETS         = $(PROGRAMS) $(shared_build) $(other_targets)
> +sbin_PROGRAMS   = $(PROGRAM_NAME)
> +TARGETS         = $(sbin_PROGRAMS) $(shared_build) $(other_targets)

Yow.  That defies every naming convention I've ever observed.  Can't we
pick one case or the other?  Perhaps even "SPROGRAMS" vs PROGRAMS, or
"SYSPROGRAMS"?

> Modified: httpd/httpd/branches/2.4.x/build/rpm/httpd.spec.in
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/build/rpm/httpd.spec.in?rev=1220867&r1=1220866&r2=1220867&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/build/rpm/httpd.spec.in (original)
> +++ httpd/httpd/branches/2.4.x/build/rpm/httpd.spec.in Mon Dec 19 17:27:13 2011

>  %{_sbindir}/ab

sbin?

>  %{_sbindir}/logresolve
>  %{_sbindir}/httxt2dbm

sbin?

>  %{_sbindir}/apxs

sbin?

None of these require the user to be administrator, except to use the
apxs -i option.  Not really sure if these make sense.  Any pointers to
a decent canonical definition of sbin v bin?

> --- httpd/httpd/branches/2.4.x/support/Makefile.in (original)
> +++ httpd/httpd/branches/2.4.x/support/Makefile.in Mon Dec 19 17:27:13 2011
> @@ -3,8 +3,9 @@ DISTCLEAN_TARGETS = apxs apachectl dbmma
>  
>  CLEAN_TARGETS = suexec
>  
> -PROGRAMS = htpasswd htdigest rotatelogs logresolve ab htdbm htcacheclean httxt2dbm $(NONPORTABLE_SUPPORT)
> -TARGETS  = $(PROGRAMS)
> +bin_PROGRAMS = htpasswd htdigest htdbm
> +sbin_PROGRAMS = rotatelogs logresolve ab htcacheclean httxt2dbm $(NONPORTABLE_SUPPORT)

Here again, pick a case?


Mime
View raw message