Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83C507CF6 for ; Thu, 3 Nov 2011 16:09:30 +0000 (UTC) Received: (qmail 10737 invoked by uid 500); 3 Nov 2011 16:09:29 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 10675 invoked by uid 500); 3 Nov 2011 16:09:29 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 10667 invoked by uid 99); 3 Nov 2011 16:09:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 16:09:29 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [173.201.192.103] (HELO p3plsmtpa06-02.prod.phx3.secureserver.net) (173.201.192.103) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 03 Nov 2011 16:09:20 +0000 Received: (qmail 28866 invoked from network); 3 Nov 2011 16:08:59 -0000 Received: from unknown (76.252.112.72) by p3plsmtpa06-02.prod.phx3.secureserver.net (173.201.192.103) with ESMTP; 03 Nov 2011 16:08:58 -0000 Message-ID: <4EB2BC6A.4070200@rowe-clan.net> Date: Thu, 03 Nov 2011 11:08:10 -0500 From: "William A. Rowe Jr." User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r1189985 - in /httpd/httpd/trunk: include/httpd.h include/util_varbuf.h modules/filters/mod_substitute.c server/util.c References: <20111027201538.B93382388A32@eris.apache.org> <4EAA5468.3090509@rowe-clan.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 11/3/2011 1:29 AM, Stefan Fritsch wrote: > >> Not acceptable. Choose a bound. unlimited is not acceptable. > > What can a content filter do to handle the error? Does returning AP_FILTER_ERROR do any > good? The headers may have been sent already. I'd suggest a top bound of 1MB, if the admin configures mod_substitute such that they approach it, /shrug. If they surpass it... obviously some noise at [error] level and yes, it seems we would need to abort.