Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <4EB110F0.9090105@vodafone.com>
Date: Wed, 02 Nov 2011 10:44:16 +0100
From: =?ISO-8859-1?Q?R=FCdiger_Pl=FCm?= <ruediger.pluem@vodafone.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de;
 rv:1.9.2.23) Gecko/20110920 SUSE/3.1.15 Thunderbird/3.1.15
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: prefetch proxy
References: <1B1ED6D5-E3B3-42D9-95EA-AD748CEF607B@jaguNET.com>
In-Reply-To: <1B1ED6D5-E3B3-42D9-95EA-AD748CEF607B@jaguNET.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit


Am 01.11.2011 21:23, schrieb Jim Jagielski:
> In mod_proxy_http we have:
>
>      /* Prefetch MAX_MEM_SPOOL bytes
>       *
>       * This helps us avoid any election of C-L v.s. T-E
>       * request bodies, since we are willing to keep in
>       * memory this much data, in any case.  This gives
>       * us an instant C-L election if the body is of some
>       * reasonable size.
>       */
>      temp_brigade = apr_brigade_create(p, bucket_alloc);
>      do {
>          status = ap_get_brigade(r->input_filters, temp_brigade,
>                                  AP_MODE_READBYTES, APR_BLOCK_READ,
>                                  MAX_MEM_SPOOL - bytes_read);
>          if (status != APR_SUCCESS) {
>              ap_log_error(APLOG_MARK, APLOG_ERR, status, r->server,
>                           "proxy: prefetch request body failed to %pI (%s)"
>                           " from %s (%s)",
>                           p_conn->addr, p_conn->hostname ? p_conn->hostname: "",
>                           c->remote_ip, c->remote_host ? c->remote_host: "");
>              return HTTP_BAD_REQUEST;
>          }
>
>          apr_brigade_length(temp_brigade, 1,&bytes);
>          bytes_read += bytes;
>
> However, I see times when status could be APR_EAGAIN. IMO, it doesn't
> make sense to error out here in that case. Right?

Why should it be EAGAIN with a blocking read?

Regards

R�diger