Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C112995B for ; Mon, 28 Nov 2011 16:32:29 +0000 (UTC) Received: (qmail 70853 invoked by uid 500); 28 Nov 2011 16:32:28 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 70798 invoked by uid 500); 28 Nov 2011 16:32:28 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 70790 invoked by uid 99); 28 Nov 2011 16:32:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2011 16:32:28 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [188.40.99.202] (HELO eru.sfritsch.de) (188.40.99.202) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2011 16:32:21 +0000 Received: from [10.1.1.6] (helo=k.localnet) by eru.sfritsch.de with esmtp (Exim 4.72) (envelope-from ) id 1RV47c-0003S4-Gx for dev@httpd.apache.org; Mon, 28 Nov 2011 17:32:00 +0100 From: Stefan Fritsch To: dev@httpd.apache.org Subject: Re: mod_xml2enc comments Date: Mon, 28 Nov 2011 17:31:59 +0100 User-Agent: KMail/1.13.7 (Linux/3.1.0-1-amd64; KDE/4.6.5; x86_64; ; ) References: <20111111033340.GA4935@manyfish.co.uk> <9060C853-5DEE-4E7F-892A-6AAB495FF283@webthing.com> In-Reply-To: <9060C853-5DEE-4E7F-892A-6AAB495FF283@webthing.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201111281731.59908.sf@sfritsch.de> X-Virus-Checked: Checked by ClamAV on apache.org On Sunday 13 November 2011, Nick Kew wrote: > Indeed, checking those return values would be better. May have > been lost when I separated out the i18n code from its origins in > markup filtering. I have added some error checks and a few ap_asserts(). Do you want to review it before I merge it into 2.4? Do you have some setup where you can test the change?