httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: svn commit: r1202255 - /httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
Date Tue, 15 Nov 2011 17:17:33 GMT
On Tue, 15 Nov 2011, pquerna@apache.org wrote:

> Author: pquerna
> Date: Tue Nov 15 15:49:19 2011
> New Revision: 1202255
>
> URL: http://svn.apache.org/viewvc?rev=1202255&view=rev
> Log:
> disable mod_reqtimeout if not configured

Why that? We have just changed the default to be enabled in r1199447 and 
several developers at the hackathon agreed to this change.

>
> Modified:
>    httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
>
> Modified: httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_reqtimeout.c?rev=1202255&r1=1202254&r2=1202255&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/filters/mod_reqtimeout.c (original)
> +++ httpd/httpd/trunk/modules/filters/mod_reqtimeout.c Tue Nov 15 15:49:19 2011
> @@ -340,6 +340,11 @@ static int reqtimeout_init(conn_rec *c)
>         return DECLINED;
>     }
>
> +    if (cfg->header_timeout == UNSET && cfg->body_timeout == UNSET) {
> +        /* if everything is unset, skip by default. */
> +        return DECLINED;
> +    }
> +
>     ccfg = apr_pcalloc(c->pool, sizeof(reqtimeout_con_cfg));
>     ccfg->type = "header";
>     if (cfg->header_timeout != UNSET) {
>
>
>

Mime
View raw message