httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@apache.org>
Subject Re: svn commit: r1205423 - in /httpd/httpd/trunk/modules: cache/mod_cache.c mappers/mod_negotiation.c
Date Thu, 24 Nov 2011 14:42:52 GMT

On Nov 23, 2011, at 4:52 PM, Graham Leggett wrote:

> On 23 Nov 2011, at 10:13 PM, Stefan Fritsch wrote:
> 
>>> -    return OK;
>>> +    return ap_pass_brigade_fchk(r, out,
>>> +                                apr_psprintf(r->pool,
>>> +                                             "cache_quick_handler(%s): ap_pass_brigade
returned",
>>> +                                             cache->provider_name));
>>> }
>> 
>> This means we call apr_psprintf even if everything went well. That's far from optimal.
Maybe really make it into a macro, then the apr_psprintf would only be executed on error?
> 
> Or perhaps use varargs for the message?
> 

+1... will get to it when I can unless someone beats me
to it ;)


Mime
View raw message