httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: Effective IP address / real IP address
Date Sun, 20 Nov 2011 16:25:46 GMT
On 20 Nov 2011, at 1:37 AM, Jeff Trawick wrote:

> On Sat, Nov 19, 2011 at 2:46 PM, Stefan Fritsch <sf@sfritsch.de>  
> wrote:
>> On Saturday 19 November 2011, Graham Leggett wrote:
>>>> The correction is simple; promote the remote_ip up to the request
>>>> rec and log/use for authentication that r->remote_ip throughout
>>>> httpd.  Introduce a wire client logging tag for c->remote_ip.
>>>
>>> This is a lot simpler and cleaner I think, let me come up with an
>>> alternative patch.
>>
>> I also think this is preferable. The hook approach adds unneeded
>> complexity and users of mod_remoteip would also need to change their
>> log formats.
>
> Yeah, only needing to add a special .conf for LB configurations would
> be nice (i.e., not touching/reconfiguring anything else)

This is the alternative I've come up with, again needing docs and in- 
principle. A logging option has been attached to log the raw IP  
address. Separately, I've attached a patch for mod_remoteip. Thoughts?

Regards,
Graham
--


Mime
View raw message