httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Igor Galić <i.ga...@brainsware.org>
Subject Re: mod_xml2enc comments
Date Mon, 28 Nov 2011 16:46:30 GMT


----- Original Message -----
> On Mon, 28 Nov 2011 17:31:59 +0100
> Stefan Fritsch <sf@sfritsch.de> wrote:
> 
> > On Sunday 13 November 2011, Nick Kew wrote:
> > > Indeed, checking those return values would be better.  May have
> > > been lost when I separated out the i18n code from its origins in
> > > markup filtering.
> > 
> > I have added some error checks and a few ap_asserts(). Do you want
> > to
> > review it before I merge it into 2.4? Do you have some setup where
> > you
> > can test the change?
> 
> Great, thanks!
> 
> Anything that might change behaviour outside of an error path?
> If all you're doing is addressing Joe's concerns (whether by design
> or coincidence) then please go right ahead and commit.

CTR (:

> --
> Nick Kew

i

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Mime
View raw message