httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <>
Subject Re: svn commit: r1202255 - /httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
Date Wed, 16 Nov 2011 21:47:30 GMT
On 11/16/2011 10:20 AM, Paul Querna wrote:
> I am 100% +1 to adding conf commands to the default configuration in
> the httpd.conf, but what I do not like is that having just a
> LoadModule with nothing else causes reqtimeout to do work.  It is too
> trivial for people to have accidental load modules in many distros.

+1; in this case it will be tricky.  This would be a per listener
or per phys-vhost option.  Although it could be a per-named-vhost
option, it makes next to no sense during the request headers input
phase when no host: will be parsed.

Will people be confused by a directive that does nothing when placed
in a named vhost?  Or should this just be global-only and forget
about it?  It would be nice to cripple this module, say, for the
intranet side of a server, and enable the overhead only on the
external side.

There's also nothing wrong with having it default to enabled, provided
the admin can disable it most of the time if they choose, for speed.

View raw message