httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Issac Goldstand <mar...@beamartyr.net>
Subject Re: setting TZ env var
Date Wed, 16 Nov 2011 07:25:27 GMT
On 16/11/2011 01:06, William A. Rowe Jr. wrote:
> On 11/15/2011 4:28 PM, Issac Goldstand wrote:
>>
>> I'd likely -1 anything that assumed without allowing the user to specify
>> an override.
>
> what on earth is wrong with
>
> --- ../httpd-2.x/support/apachectl.in   (revision 1198625)
> +++ ../httpd-2.x/support/apachectl.in   (working copy)
> @@ -44,6 +44,9 @@
>  # the path to your httpd binary, including options if necessary
>  HTTPD='@exp_sbindir@/@progname@'
>  #
> +# desired local timezone representation for logs
> +TZ=GMT+0000
> +#
>  # pick up any necessary environment variables
>  if test -f @exp_sbindir@/envvars; then
>    . @exp_sbindir@/envvars
>
> or...
>
> SetEnv TZ GMT+0000
>
> There you go, two mechanisms "allowing the user to specify
> an override"
>
> Can we quit inventing redundant directives?
>
> I'm certainly -1 on such a directive.  I'm totally +1 if someone
> wants to document the appropriate use of the TZ variable.
>
> And I'd be very cool with ensuring that we tzset() after allowing
> conf parsing/SetEnv processing and before forking.

Good point - that's definitely fair enough, just need to make sure it's
documented in the right place.

  Issac
 

Mime
View raw message