httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r1205423 - in /httpd/httpd/trunk/modules: cache/mod_cache.c mappers/mod_negotiation.c
Date Wed, 23 Nov 2011 21:52:57 GMT
On 23 Nov 2011, at 10:13 PM, Stefan Fritsch wrote:

>> -    return OK;
>> +    return ap_pass_brigade_fchk(r, out,
>> +                                apr_psprintf(r->pool,
>> +                                             "cache_quick_handler(%s): ap_pass_brigade
returned",
>> +                                             cache->provider_name));
>> }
> 
> This means we call apr_psprintf even if everything went well. That's far from optimal.
Maybe really make it into a macro, then the apr_psprintf would only be executed on error?

Or perhaps use varargs for the message?

Regards,
Graham
--


Mime
View raw message