httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: mod_xml2enc: warning: variable 'rv' set but not used
Date Tue, 29 Nov 2011 22:25:42 GMT
On Tuesday 29 November 2011, Graham Leggett wrote:
> Hi all,
> 
> I've noticed some warnings in mod_xml2enc:
> 
> mod_xml2enc.c: In function 'fix_skipto':
> mod_xml2enc.c:123:18: warning: variable 'rv' set but not used
> [-Wunused-but-set-variable] mod_xml2enc.c: In function
> 'sniff_encoding':
> mod_xml2enc.c:167:18: warning: variable 'rv' set but not used
> [-Wunused-but-set-variable]
> 
> Should we be handling the errors here?
> 
>                     rv = apr_brigade_partition(ctx->bbsave,
> (p-ctx->buf), &bstart);

These are fixed in trunk r1206850. I intend to backport to 2.4. But if 
you have some time, a second set of eyeballs can't hurt.

Mime
View raw message