httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: mod_xml2enc comments
Date Mon, 28 Nov 2011 16:43:53 GMT
On Mon, 28 Nov 2011 17:31:59 +0100
Stefan Fritsch <sf@sfritsch.de> wrote:

> On Sunday 13 November 2011, Nick Kew wrote:
> > Indeed, checking those return values would be better.  May have
> > been lost when I separated out the i18n code from its origins in
> > markup filtering.
> 
> I have added some error checks and a few ap_asserts(). Do you want to 
> review it before I merge it into 2.4? Do you have some setup where you 
> can test the change?

Great, thanks!

Anything that might change behaviour outside of an error path?
If all you're doing is addressing Joe's concerns (whether by design
or coincidence) then please go right ahead and commit.

-- 
Nick Kew

Mime
View raw message