Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Date: Wed, 5 Oct 2011 23:26:35 +0200 (CEST)
From: Stefan Fritsch <sf@sfritsch.de>
To: dev@httpd.apache.org
Subject: Re: svn commit: r1178079 - in /httpd/httpd/trunk: CHANGES
In-Reply-To: <4E8BA0E6.2010007@gknw.net>
Message-ID: <alpine.DEB.2.00.1110052319210.5632@eru.sfritsch.de>
References: <4E8BA0E6.2010007@gknw.net>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed

On Tue, 4 Oct 2011, Gregg L. Smith wrote:
> It looks as if ap_max_mem_free was not originally intended to be exported. 
> But if it is going to be used in mod_ssl, it's is going to need to be no?

Oops, I missed that. In principle there is the same problem with 
mod_mpm_event, but that is only built under Unix where the missing 
AP_DECLARE_DATA makes no difference.

Fixed in r1179448.

Cheers,
Stefan

>
> Linking...
>
>   Creating library .\Release/mod_ssl.lib and object .\Release/mod_ssl.exp
> ssl_engine_init.obj : error LNK2001: unresolved external symbol 
> _ap_max_mem_free
> .\Release\mod_ssl.so : fatal error LNK1120: 1 unresolved externals
>
> This seems to work for Win & Netware
>
> Index: include/mpm_common.h
> ===================================================================
> --- include/mpm_common.h    (revision 1178660)
> +++ include/mpm_common.h    (working copy)
> @@ -314,7 +314,7 @@
> int ap_signal_server(int *, apr_pool_t *);
> void ap_mpm_rewrite_args(process_rec *);
>
> -extern apr_uint32_t ap_max_mem_free;
> +AP_DECLARE_DATA apr_uint32_t ap_max_mem_free;
> extern const char *ap_mpm_set_max_mem_free(cmd_parms *cmd, void *dummy,
>                                            const char *arg);
>
>
>
>
> Cheers,
>
> Gregg
>