httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stefan novak <lms.bruba...@gmail.com>
Subject Re: PATCH mod_fcgid compile fails
Date Wed, 05 Oct 2011 15:47:27 GMT
>
> this is only a warning, are You sure httpd fails to build ?
>

yes, httpd fails to build with this lines :(
maybe another compile flag will help, i'm not sure...


>
> > The following patch helps, but i dont know if its the right solution.
> > 1129#centos6-build:diff modules/fcgid/fcgid_mutex_unix.c
> > ../mod_fcgid-2.3.6/modules/fcgid/fcgid_mutex_unix.c
> > 118c118
> > <     mkstemp(lockfile);
> > ---
> >>     tmpnam(lockfile);
> > Can someone check it?
>
> I think this won't work
>
> from man
>
> The  mkstemp()  function generates a unique temporary filename from
> template, creates and opens the file, and returns an open file
> descriptor for the file.
>
> The  tmpnam() function returns a pointer to a string that is a valid
> filename, and such that a file with this name did not exist at some
> point in time
>
> tmpnam() creates a temporary filename in lockfile which is used by
> apr_global_mutex_create()
>
> mkstemp() won't touch lockfile so apr_global_mutex_create() will get
> always same empty string, i think this might work on some platforms
> where default lock mechanism doesn't need a filename
>
>
sounds not so good.
is anyone able to produce a better patch, i'm not a C programer :(

thx S.Novak

Mime
View raw message