httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: Really big regex results from ap_pregsub
Date Fri, 14 Oct 2011 17:35:44 GMT
On 10/14/2011 7:46 AM, Jim Jagielski wrote:
> 
> On Oct 13, 2011, at 4:30 PM, William A. Rowe Jr. wrote:
>>
>> The largest string value applicable to header values, to URI's
>> and any presentation string (to errorlog or access log etc) is
>> MAX_STRING_LEN.  The longest config line is MAX_STRING_LEN.
>> I don't see a lot of reasons supporting something longer.
> 
> Pre-2.4 that is true, but not on trunk…

Trunk might be even simpler... an ap_pnregsub taking a max-string len arg?

>> This was always unambiguous, NULL on error.  The doxygen has *nothing*
>> to say about the result value.
>>
>> So... I'd suggest we fix cases that did not expect NULL and return NULL
>> on any substitution failure.  I don't even see the need for an MMN bump.
> 
> For trunk? Yes. For pre-2.4? Not so sure (due to external modules)…
> but I'll go along with it.

I'd love to see some additional eyes on the use cases and proposed solutions
so we can put this to bed.


Mime
View raw message